[PS-13958] - Extend options for listing jobs #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
domino/domino.py
Outdated
| project_id: str, | ||
| order_by: str = "number", | ||
| sort_by: str = "desc", | ||
| page_size: int = 3, |
There was a problem hiding this comment.
Can we keep the page_size in None as a default value? If this default value is enforced by Domino (I see the 3 in the old description) and changes in the future, we might want to also have that change applied seamless here.
What do you think?
There was a problem hiding this comment.
We can. I had doubts about hard-coding any of the API defaults for the same reason.
I guess page_size makes the biggest difference, because it limits how many results you see, whereas the others are just filtering and sorting them, right?
There was a problem hiding this comment.
Yeap, I agree. The rest will probably be something that users would manually tweak if needed 👍
ddl-s-rodriguez
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
PS-13958
What issue does this pull request solve?
Extends the query functionality of jobs_list() to include as many of the options available in Domino's REST API as possible.
What is the solution?
Added additional arguments and set their default values to match those in the REST API.
Testing
Tested by listing previous jobs in a project. As the function explicitly sends the default API values, it uses all of the query parameters by default.
Pull Request Reminders
References (optional)